Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 10719 infinite order fixture loading #10733

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Fix 10719 infinite order fixture loading #10733

merged 2 commits into from
Oct 20, 2019

Conversation

igormukhingmailcom
Copy link
Contributor

Q A
Branch? 1.6 (as it present only at 1.6 and not present at 1.5 or 1.4)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10719
License MIT

@igormukhingmailcom igormukhingmailcom requested a review from a team as a code owner October 2, 2019 12:32
@ostrolucky
Copy link
Contributor

looks like all changes except custom_fixtures can be backported to < 1.6

pamil
pamil reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this PR to the 1.6 branch?

src/Sylius/Bundle/CoreBundle/Fixture/Factory/OrderExampleFactory.php Outdated Show resolved Hide resolved
@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Oct 4, 2019
@igormukhingmailcom igormukhingmailcom force-pushed the fix-10719-infinite-order-fixture-loading branch from 00a0e4e to 807f0e0 Compare October 10, 2019 09:42
@lchrusciel lchrusciel changed the base branch from master to 1.6 October 16, 2019 05:51
lchrusciel
lchrusciel reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Igor,

thanks a lot for this bugfix. Can you rebase one more time to 1.6 as there are some conflicts?

src/Sylius/Component/Core/Repository/ProductRepositoryInterface.php Outdated Show resolved Hide resolved
@ostrolucky
Copy link
Contributor

1.6 (as it present only at 1.6 and not present at 1.5 or 1.4)

This is false though, it's on 1.4 too

@igormukhingmailcom igormukhingmailcom force-pushed the fix-10719-infinite-order-fixture-loading branch from 807f0e0 to 8dcd074 Compare October 16, 2019 13:37
@igormukhingmailcom
Copy link
Contributor Author

igormukhingmailcom commented Oct 16, 2019 •
edited
Loading

@ostrolucky

This is false though, it's on 1.4 too

At 1.4 there is another file to fix - OrderFixture rather than OrderExampleFactory. I guess you can make PR for it if you want.

@ostrolucky
Copy link
Contributor

true

@lchrusciel lchrusciel merged commit 60787e3 into Sylius:1.6 Oct 20, 2019
@lchrusciel
Copy link
Member

Thanks, Igor! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@pamil pamil Awaiting requested review from pamil

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igormukhingmailcom @ostrolucky @lchrusciel @pamil