Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: TimestampableInterface to core TaxonInterface (fixes #10728) #10734

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Added: TimestampableInterface to core TaxonInterface (fixes #10728) #10734

merged 1 commit into from
Nov 8, 2019

Conversation

igormukhingmailcom
Copy link
Contributor

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10728
License MIT

@igormukhingmailcom igormukhingmailcom requested a review from a team as a code owner October 2, 2019 12:37
@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Oct 4, 2019
@pamil
Copy link
Contributor

pamil commented Oct 4, 2019

Could you add a line to UPGRADE-1.7.md about this change? It's very unlikely, but it can be a BC break for some.

@igormukhingmailcom
Copy link
Contributor Author

Could you add a line to UPGRADE-1.7.md about this change? It's very unlikely, but it can be a BC break for some.

I'm on 1.3, and there are no UPGRADE-1.7.md... How that usually handled?

@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

@igormukhingmailcom it should appear after you rebase your PR with the master branch - we can't merge it into any previous version (BC reasons), and even if we could, currently only 1.5+ versions are supported.

@lchrusciel
Copy link
Member

Hey Kamil.

Do we really need to add a notice to the UPGRADE file? According to our bc promise we are fine without it :)

I would vote for merge ;)

@igormukhingmailcom igormukhingmailcom force-pushed the fix-10728-taxon-timestampable-interface branch from f5bfb52 to 9108d82 Compare October 20, 2019 12:00
@igormukhingmailcom
Copy link
Contributor Author

Models & model interfaces
In order to fulfill the constant Sylius’ need to evolve, model interfaces are excluded from this BC promise.

Rebased to 1.5

@Zales0123 Zales0123 changed the base branch from master to 1.5 November 8, 2019 10:01
@Zales0123 Zales0123 merged commit c6d1010 into Sylius:1.5 Nov 8, 2019
@Zales0123
Copy link
Member

Thank you, Igor! 🎉

@pamil pamil mentioned this pull request Nov 8, 2019
Closed
@igormukhingmailcom igormukhingmailcom deleted the fix-10728-taxon-timestampable-interface branch March 5, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Awaiting requested review from Zales0123

@pamil pamil Awaiting requested review from pamil

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igormukhingmailcom @pamil @lchrusciel @Zales0123