Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch statement conditions #10748

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Switch statement conditions #10748

merged 1 commit into from
Oct 10, 2019

Conversation

mikemix
Copy link
Contributor

@mikemix mikemix commented Oct 8, 2019

It's much cheaper to run a quick instanceof check first. If it returns false, we skip entire decision manager process. This is better for performance actually, at least when the user is not authenticated. Simple things do matter.

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@mikemix mikemix requested a review from a team as a code owner October 8, 2019 11:33
@pamil pamil added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Oct 10, 2019
@pamil pamil changed the base branch from master to 1.5 October 10, 2019 16:14
@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 6269d24 into Sylius:1.5 Oct 10, 2019
@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

Thank you, Mike! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants