Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add tag that stripe is outdated and add SCA note #10755

Merged
merged 2 commits into from Oct 15, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Oct 10, 2019

Q A
Branch? 1.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Screenshot 2019-10-14 at 16 02 31

@Tomanhez Tomanhez requested a review from a team as a code owner October 10, 2019 08:29
@Tomanhez Tomanhez changed the title [Docs] Outdated stripe and add SCA note [Docs] Add tag that stripe is outdated and add SCA note Oct 10, 2019
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 10, 2019
docs/cookbook/payments/stripe.rst Outdated Show resolved Hide resolved
docs/cookbook/payments/stripe.rst Outdated Show resolved Hide resolved
docs/cookbook/payments/stripe.rst Outdated Show resolved Hide resolved
docs/cookbook/payments/stripe.rst Outdated Show resolved Hide resolved
docs/cookbook/payments/stripe.rst Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the sca-handling branch 2 times, most recently from b882d78 to 2596c14 Compare October 14, 2019 14:03
@GSadee GSadee changed the base branch from master to 1.4 October 15, 2019 06:00
@GSadee
Copy link
Member

GSadee commented Oct 15, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "sca-handling" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee merged commit f31b3b3 into Sylius:1.4 Oct 15, 2019
@GSadee
Copy link
Member

GSadee commented Oct 15, 2019

Thank you, Tomasz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants