[ShippingMethod] Do not allow to specify shipping charge below 0 #10790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Potential Bug
Zales0123
force-pushed
the
do-not-allow-to-set-shipping-method-fee-below-0
branch
from
efd37c6
to
031c398
Compare
lchrusciel
reviewed
Oct 23, 2019
| @@ -20,3 +20,15 @@ Feature: Shipping method flat rate per shipment calculator validation | |||
| When I try to add it | |||
| Then I should be notified that amount for "Web" channel should not be blank | |||
| And shipping method with name "FedEx Carrier" should not be added | |||
|
|
|||
| @ui @javascript | |||
lchrusciel
approved these changes
Oct 23, 2019
GSadee
approved these changes
Oct 24, 2019
...shipping/managing_shipping_methods/shipping_method_flat_rate_per_shipment_validation.feature
Outdated
Show resolved
Hide resolved
...res/shipping/managing_shipping_methods/shipping_method_flat_rate_per_unit_validation.feature
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingShippingMethodsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShippingBundle/Form/Type/Calculator/FlatRateConfigurationType.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShippingBundle/Resources/translations/validators.en.yml
Show resolved
Hide resolved
lchrusciel
approved these changes
Oct 25, 2019
|
Thank you, Mateusz! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though one could argue that it's a useful feature 馃槃 I believe we should always accomplish such functionality with a properly configured shipping promotion 馃枛