Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename shop user factory to help autowiring #10820

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Rename shop user factory to help autowiring #10820

merged 1 commit into from
Nov 6, 2019

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 6, 2019

Q A
Branch? 1.5
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

When you override this example factory. You have to manually wire this argument.
This change helps Resource bundle to autowire this argument.

@loic425 loic425 requested a review from a team as a code owner November 6, 2019 12:09
@loic425 loic425 changed the base branch from master to 1.5 November 6, 2019 12:09
@pamil pamil added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 6, 2019
@pamil pamil merged commit be458d1 into Sylius:1.5 Nov 6, 2019
@pamil
Copy link
Contributor

pamil commented Nov 6, 2019

Thank you, Loïc! 🎉

@loic425 loic425 deleted the fix/shop-user-example-factory branch November 6, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loic425 @pamil