Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Typo at grid configuration example #10825

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

igormukhingmailcom
Copy link
Contributor

Q A
Branch? 1.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@igormukhingmailcom igormukhingmailcom requested a review from a team as a code owner November 6, 2019 14:47
@pamil pamil added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Nov 6, 2019
@pamil
Copy link
Contributor

pamil commented Nov 6, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil changed the base branch from 1.4 to 1.5 November 6, 2019 17:26
@pamil pamil merged commit 5ff7ffb into Sylius:1.5 Nov 6, 2019
@pamil
Copy link
Contributor

pamil commented Nov 6, 2019

Thanks, Igor! 🥇

@igormukhingmailcom igormukhingmailcom deleted the patch-2 branch November 6, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants