Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Psalm] Fix the build after Symfony 4.4 update #10873

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 21, 2019

No description provided.

@pamil pamil requested a review from a team as a code owner November 21, 2019 18:55
@pamil pamil added Critical Issues and PRs, which are critical and should be fixed ASAP. Maintenance CI configurations, READMEs, releases, etc. labels Nov 21, 2019
@@ -112,23 +114,23 @@ private function getProperFinalMessage(bool $errored): string

private function getSyliusLogo(): string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, it renders correctly :)

@GSadee GSadee merged commit bf467db into Sylius:master Nov 22, 2019
@GSadee
Copy link
Member

GSadee commented Nov 22, 2019

Thanks, Kamil! 🥇

@pamil pamil deleted the psalm-fix branch November 22, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Issues and PRs, which are critical and should be fixed ASAP. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants