Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing colon #10901

Merged
merged 1 commit into from Dec 11, 2019
Merged

Fix missing colon #10901

merged 1 commit into from Dec 11, 2019

Conversation

reyostallenberg
Copy link
Contributor

Q A
Branch? 1.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets n.a.
License MIT

@reyostallenberg reyostallenberg requested a review from a team as a code owner December 3, 2019 14:31
@reyostallenberg reyostallenberg changed the title atch 1 Fix missing colon Dec 3, 2019
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 9, 2019
@lchrusciel lchrusciel changed the base branch from 1.4 to 1.5 December 11, 2019 12:56
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@reyostallenberg
Copy link
Contributor Author

I think this is a rebased version. (Would be nice if there was a PR template which stated to which branch to point proposed changes)

lchrusciel
lchrusciel approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a note in pull request template, but it is outdated: https://raw.githubusercontent.com/Sylius/Sylius/master/.github/PULL_REQUEST_TEMPLATE.md

@lchrusciel
Copy link
Member

lchrusciel commented Dec 11, 2019 •
edited

Updated: #10923

@pamil pamil merged commit cb0268c into Sylius:1.5 Dec 11, 2019
@pamil
Copy link
Contributor

pamil commented Dec 11, 2019

Thanks, Reyo! 🥇

@reyostallenberg reyostallenberg deleted the patch-2 branch March 29, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reyostallenberg @lchrusciel @pamil @Zales0123