[Taxation] [Shipping] Fixed issue with shipping zones available to select in tax rate form (and the other way) #10909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plewandowski
force-pushed
the
issue_shipping_zone_can_be_selected_as_tax_rate_zone
branch
from
c91f560
to
44265ec
Compare
lchrusciel
approved these changes
Dec 6, 2019
src/Sylius/Bundle/CoreBundle/Form/Extension/TaxRateTypeExtension.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Tests/Form/Type/ZoneChoiceTypeTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Tests/Form/Type/ZoneChoiceTypeTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Tests/Form/Type/ZoneChoiceTypeTest.php
Outdated
Show resolved
Hide resolved
…lect in tax rate form (and the other way) - added zone_scope option to ZoneChoiceType to pass desired scope - for BC default scope is "ALL" - modified ShippingMethodTypeExtension and TaxRateTypeExtension to pass correct zone_scope option - form type test for ZoneChoiceType [Taxation] [Shipping] Fixed issue with shipping zones available to select in tax rate form (and the other way) - added zone_scope option to ZoneChoiceType to pass desired scope - for BC default scope is "ALL" - modified ShippingMethodTypeExtension and TaxRateTypeExtension to pass correct zone_scope option - form type test for ZoneChoiceType
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
lchrusciel
force-pushed
the
issue_shipping_zone_can_be_selected_as_tax_rate_zone
branch
from
44265ec
to
914c272
Compare
…on.php Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
…ypeTest.php Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
…ypeTest.php Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
…ypeTest.php Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
lchrusciel
approved these changes
Dec 7, 2019
|
Thank you, Piotr! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with shipping zones available to select in tax rate form (and the other way)
btw. Maybe this is not something that people usually write in PRs, but it is actually my first contribution to Sylius, so I feel that I should write something more in this important moment... I would like to dedicate this PR to my wife who always supports me and never complains about coding till late :-)