[Behat] Rework behat - using attributes instead class/id in address and shipping page #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
changed the title
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
3 times, most recently
from
40799fd
to
edaf304
Compare
AdamKasp
changed the title
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
from
edaf304
to
82921fd
Compare
pamil
suggested changes
Dec 12, 2019
Zales0123
added
DX
AdamKasp
changed the title
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
12 times, most recently
from
7e84f45
to
6bf8690
Compare
GSadee
reviewed
Dec 18, 2019
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
from
6bf8690
to
f765ed4
Compare
pamil
reviewed
Dec 18, 2019
src/Sylius/Bundle/ShopBundle/Resources/views/Common/Form/_login.html.twig
Outdated
Show resolved
Hide resolved
pamil
added
Behat
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
from
f765ed4
to
001efe2
Compare
AdamKasp
force-pushed
the
rework-behat-checkout-pages-part-2
branch
from
001efe2
to
905cf61
Compare
GSadee
approved these changes
Dec 19, 2019
pamil
approved these changes
Dec 19, 2019
|
Thanks, Adam! 🎉 |
GSadee
added a commit
that referenced
this pull request
Dec 19, 2019
…/id part in payment page (AdamKasp) This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | based on #10921 | License | MIT <!-- - Bug fixes must be submitted against the 1.5 or 1.6 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> rework payment page Commits ------- 0907ab9 Rework behats - checkout paymentPage
lchrusciel
reviewed
Dec 19, 2019
| {% include '@SyliusShop/Common/Form/_address.html.twig' with {'form': form.shippingAddress, 'order': order} %} | ||
| {{ form_row(form.differentBillingAddress, {'attr': {'data-toggles': 'sylius-billing-address'}}) }} | ||
| {% include '@SyliusShop/Common/Form/_address.html.twig' with {'form': form.shippingAddress, 'order': order, 'type': 'shipping'} %} | ||
| {{ form_row(form.differentBillingAddress,sylius_test_form_attribute('different-billing-address')|sylius_merge_recursive({'attr': {'data-toggles': 'sylius-billing-address'}, 'label_attr': {'data-test-different-billing-address-label': ''}} )) }} |
There was a problem hiding this comment.
Suggested change
| {{ form_row(form.differentBillingAddress,sylius_test_form_attribute('different-billing-address')|sylius_merge_recursive({'attr': {'data-toggles': 'sylius-billing-address'}, 'label_attr': {'data-test-different-billing-address-label': ''}} )) }} | |
| {{ form_row(form.differentBillingAddress, sylius_test_form_attribute('different-billing-address') | sylius_merge_recursive({'attr': {'data-toggles': 'sylius-billing-address'}, 'label_attr': {'data-test-different-billing-address-label': ''}} )) }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing class/id by attributes in AddressPage, selectShippingPage and related html
for now, I left elements related to JS without changes, because simple attribute generates errors, it will be done in the near feature.