Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Symfony ^4.4 #10970

Merged
merged 3 commits into from Jan 16, 2020
Merged

Require Symfony ^4.4 #10970

merged 3 commits into from Jan 16, 2020

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Dec 18, 2019

No description provided.

@pamil pamil requested a review from a team as a code owner December 18, 2019 13:25
@pamil pamil added Maintenance CI configurations, READMEs, releases, etc. Symfony 5 labels Dec 18, 2019
@pamil
Copy link
Contributor Author

pamil commented Dec 27, 2019

No idea why PHP 7.2 application build fails :/

@oallain
Copy link
Member

oallain commented Jan 11, 2020

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

I feel like it's just a lag time that has lasted too long (more than 10 minutes).

I think relaunching the build can validate (or not) this idea ;)

@pamil pamil force-pushed the sf-44 branch 2 times, most recently from bcb5c5f to 32d60d9 Compare January 15, 2020 18:06
@pamil pamil mentioned this pull request Jan 15, 2020
Merged
Zales0123
Zales0123 reviewed Jan 16, 2020
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing some problems in the packages build it should be ready to go 💃 🚀

lchrusciel
lchrusciel approved these changes Jan 16, 2020
View reviewed changes
src/Sylius/Bundle/OrderBundle/Tests/DependencyInjection/SyliusOrderExtensionTest.php
@@ -28,17 +29,19 @@ final class SyliusOrderExtensionTest extends AbstractExtensionTestCase
*/
public function it_autoconfigures_cart_contexts_and_order_processors(): void
{
$this->markTestSkipped('Symfony 4.4 makes it impossible to test autoconfigured services this way.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this test then.

@lchrusciel lchrusciel merged commit 16205f6 into Sylius:master Jan 16, 2020
@lchrusciel
Copy link
Member

Thanks, Kamil! 🥇

@pamil pamil deleted the sf-44 branch January 16, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pamil @oallain @lchrusciel @GSadee @Zales0123 @Tomanhez