[Checkout] Make billing address the default one #11033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
Jan 17, 2020
src/Sylius/Bundle/ShopBundle/Resources/views/Checkout/Address/_form.html.twig
Outdated
Show resolved
Hide resolved
Tomanhez
approved these changes
Jan 17, 2020
GSadee
force-pushed
the
make-billing-address-default-one
branch
from
e4fa2ce
to
c976ae0
Compare
GSadee
changed the title
lchrusciel
reviewed
Jan 17, 2020
lchrusciel
approved these changes
Jan 17, 2020
| * | ||
| * It is deprecated since Sylius 1.7 and will be removed in Sylius 2.0 | ||
| */ | ||
| public function it_allows_to_address_order_with_different_shipping_and_billing_address_using_different_billing_address_flag(): void |
There was a problem hiding this comment.
We need another case when only shippingAddress will be provided.
|
Thank you, Mateusz and Grzegorz! 🥇 |
|
Sweet!! Thank you Mateusz!! |
|
TBH it was Grzegorz and Mateusz collaboration :P |
|
Thank you, Grzegorz!! :D |
lchrusciel
added a commit
that referenced
this pull request
Jan 17, 2020
… different billing address flag (GSadee) This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Related tickets | #11033 | License | MIT Commits ------- e85f134 [Checkout] Add missing unit test for using deprecated different billing address flag
lchrusciel
added a commit
that referenced
this pull request
Jan 20, 2020
This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | related with #11033 | License | MIT    <!-- - Bug fixes must be submitted against the 1.6 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- ca12e49 Change adressses order
Zales0123
added a commit
that referenced
this pull request
Jan 30, 2020
…ing and shipping addresses (GSadee) This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #11033 | License | MIT Commits ------- 43e4301 [Checkout] Add note to UPGRADE file about switching billing and shipping addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the change we need and we deserve 😄 There are a lot of files changed, but it's a change that touches a lot of places in the code.
What needs to be considered - how to keep a BC, as we change the
differentBillingAddressfield todifferentShippingAddress, which can affect customizations in some Sylius apps.