[Shipment] Ship a shipment with tracking code on the list #11066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
Jan 27, 2020
features/shipping/managing_shipments/managing_of_shipments_status.feature
Outdated
Show resolved
Hide resolved
features/shipping/managing_shipments/managing_of_shipments_status.feature
Outdated
Show resolved
Hide resolved
...ylius/Bundle/AdminBundle/Resources/views/Shipment/Grid/Action/shipWithTrackingCode.html.twig
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
providing-tracking-code-on-shipment-index
branch
from
fed1545
to
9519c18
Compare
AdamKasp
changed the title
Zales0123
reviewed
Jan 29, 2020
features/shipping/managing_shipments/managing_of_shipments_status.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Action/ShipShipmentOnIndexPageAction.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Action/ShipShipmentOnIndexPageAction.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Action/ShipShipmentOnIndexPageAction.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Action/ShipShipmentOnIndexPageAction.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/grids/shipment.yml
Outdated
Show resolved
Hide resolved
GSadee
added
Admin
AdamKasp
changed the title
AdamKasp
force-pushed
the
providing-tracking-code-on-shipment-index
branch
4 times, most recently
from
d00daa0
to
250badd
Compare
GSadee
reviewed
Jan 30, 2020
pamil
suggested changes
Jan 30, 2020
src/Sylius/Bundle/AdminBundle/Resources/config/routing/shipment.yml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
providing-tracking-code-on-shipment-index
branch
4 times, most recently
from
140ebc0
to
627f1ce
Compare
GSadee
approved these changes
Jan 31, 2020
pamil
reviewed
Jan 31, 2020
Zales0123
reviewed
Jan 31, 2020
src/Sylius/Bundle/AdminBundle/spec/Shipper/OrderShipmentShipperSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
providing-tracking-code-on-shipment-index
branch
from
627f1ce
to
d2d7de9
Compare
Zales0123
approved these changes
Jan 31, 2020
lchrusciel
reviewed
Jan 31, 2020
src/Sylius/Bundle/AdminBundle/Resources/config/routing/shipment.yml
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
providing-tracking-code-on-shipment-index
branch
from
d2d7de9
to
4318e92
Compare
…of custom action to ship a shipment
GSadee
force-pushed
the
providing-tracking-code-on-shipment-index
branch
from
84a1078
to
b0d5fce
Compare
GSadee
reviewed
Feb 3, 2020
lchrusciel
approved these changes
Feb 3, 2020
src/Sylius/Bundle/AdminBundle/Resources/views/Shipment/Grid/_ship.html.twig
Show resolved
Hide resolved
lchrusciel
approved these changes
Feb 3, 2020
GSadee
approved these changes
Feb 3, 2020
|
Thanks, Adam! 🎉 |
GSadee
added a commit
that referenced
this pull request
Feb 5, 2020
This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes for #11066 (comment) | License | MIT Based on #11066 <!-- - Bug fixes must be submitted against the 1.6 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set --> Commits ------- 782cc2e [Admin] Use shipment action for shipment grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Administrator can process shipment directly from the index page by providing a tracking code with
shipaction, i also deleted the customer column because this information is unimportant in inShippingprocess, ofc, if Admin will need this information, by order number, can check all data about the shipment.