Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Add attributes to registration page and fix summary page. #11103

Merged
merged 1 commit into from Feb 10, 2020
Merged

[Behat] Add attributes to registration page and fix summary page. #11103

merged 1 commit into from Feb 10, 2020

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Feb 7, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner February 7, 2020 07:55
@AdamKasp AdamKasp force-pushed the rework-behats-ragistration-page branch from 378aa99 to 56f2414 Compare February 7, 2020 11:18
@GSadee GSadee added Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience. labels Feb 7, 2020
@AdamKasp AdamKasp force-pushed the rework-behats-ragistration-page branch from 56f2414 to 276b76c Compare February 7, 2020 12:29
GSadee
GSadee approved these changes Feb 7, 2020
View reviewed changes
src/Sylius/Behat/Page/Shop/Cart/SummaryPage.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the rework-behats-ragistration-page branch from 572bd74 to e65ccae Compare February 8, 2020 10:42
@GSadee GSadee merged commit df601c1 into Sylius:master Feb 10, 2020
@GSadee
Copy link
Member

GSadee commented Feb 10, 2020

Thank you, Adam! 🎉

GSadee added a commit to GSadee/Sylius that referenced this pull request Feb 10, 2020
@GSadee
refactor Sylius#11103 [Behat] Add attributes to registration page and…
9b3c8cc 
… fix summary page. (AdamKasp)

This PR was merged into the 1.7-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.6 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->

Commits
-------

e65ccae Add atributes to registrationpage ans fix summary page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamKasp @GSadee @Zales0123 @lchrusciel