Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to deploy Sylius to SymfonyCloud #11130

Merged
merged 1 commit into from Feb 23, 2020

Conversation

tucksaun
Copy link
Contributor

Q A
Branch? 1.6
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

Some customers asked us some basic configuration to deploy Sylius projects to SymfonyCloud, let 's make this available to everyone 馃槂

@tucksaun tucksaun requested a review from a team as a code owner February 19, 2020 15:09
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tugdual,

thanks for adding this cookbook. It's great that this deployment works so smoothly.

Also, welcome to our community 馃憤


.. code-block:: bash

$ git add php.ini .symfony .symfony.cloud.yaml && git commit -m "SymfonyCloud configuration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have the rest of the project already committed? I mean, this is the first time git command appears, and I'm wondering if we shouldn't mention something about it earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I should probably add a simple additional step in section 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 20, 2020
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the contribution 馃挭
You've missed to include * :doc:`/cookbook/deployment/symfonycloud as the second line of cookbook/deployment/map.rst.inc :)

Without that the doc is inaccessible.

@tucksaun
Copy link
Contributor Author

thanks for review @CoderMaggie 馃憤 . I though about the index but not the map. this is updated

@lchrusciel lchrusciel merged commit d6ee985 into Sylius:1.6 Feb 23, 2020
@lchrusciel
Copy link
Member

Thanks, Tugdual! 馃

@tucksaun tucksaun deleted the symfonycloud-deployment branch February 23, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants