Bug #9738 Fix nested form collections

[vic-blt]

If there are nested form collections, the value __name__ of the sub
collection is being replaced by the parent collection index.
Which makes every new sub collection items having the same index.

Q	A
Branch?	1.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #9738
License	MIT

[lchrusciel]

Hey Victorien,

thanks for your contribution! Your change seems to be ok. We need to fix master build before we will merge your PR.

Welcome to our community! :)

[vic-blt]

Hi Lukasz,

Welcome to our community! :)

Thank you :)

[lchrusciel]

Btw. @vic-blt can you share some screenshots of the change done by this solution? Or an example code?

[vic-blt]

Without the fix :

With the fix :

You can see that without the fix, data-form-collection-index in data-prototype attribute, is already set to 0, which makes collection items having the same index because when data-prototype attribute of parent collection is modified by prototype = prototype.replace(/__name__/g, this.count);, data-form-collection-index value of sub collection is also replaced by this.count which is the index of parent collection.

[lchrusciel]

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "issue-9738-fix-nested-form-collections" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

[lchrusciel]

Thank you, Victorien! 🎉