Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to the locale code if the associated name isn't found #11391

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fallback to the locale code if the associated name isn't found #11391

merged 1 commit into from
Apr 23, 2020

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Apr 23, 2020

Q A
Branch? 1.6
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

Prevents a 500 error if the locale code has no associated name in the Intl database. Example with en_DG:

Capture d’écran 2020-04-23 à 11 19 45

@dunglas dunglas requested a review from a team as a code owner April 23, 2020 09:21
lchrusciel
lchrusciel approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Kevin,

Thanks a lot for the contribution!

I'm wondering if we should cover this with the behat as well.

@lchrusciel lchrusciel merged commit bb80716 into Sylius:1.6 Apr 23, 2020
@lchrusciel
Copy link
Member

Thanks, Kévin! 🎉

@aleksmark aleksmark mentioned this pull request May 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dunglas @lchrusciel