[UI] added display of product variant original price on product page #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
reviewed
May 25, 2020
src/Sylius/Component/Core/spec/Provider/ProductVariantsPricesProviderSpec.php
Show resolved
Hide resolved
src/Sylius/Component/Core/Provider/ProductVariantsPricesProvider.php
Outdated
Show resolved
Hide resolved
JulienLoison
force-pushed
the
feat/change-product-variant-original-price
branch
from
c8f7e40
to
8bddc52
Compare
Zales0123
approved these changes
May 26, 2020
| if ($originalPrice > $price) { | ||
| $optionMap['original-price'] = $originalPrice; | ||
| } | ||
| } |
There was a problem hiding this comment.
As I don't like nested if statements, I would go with:
if (!$this->productVariantPriceCalculator instanceof ProductVariantPricesCalculatorInterface) {
return $optionMap;
}
if ($originalPrice > $price) {
$optionMap['original-price'] = $originalPrice;
}
return $optionMap;but it's not a blocker for me 🖖
There was a problem hiding this comment.
Has @lchrusciel mentioned on the original PR, I'll try to add some original prices fixtures. I'll fix those nested if as well with the same PR.
Thanks for the review !
lchrusciel
approved these changes
May 26, 2020
|
Thanks, Julien! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up @lchrusciel's comment on #11423 about variant prices not updating on the product page or variant not displaying discount if the first variant of the product has no discount.