Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration #11624

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fix migration #11624

merged 1 commit into from
Jul 10, 2020

Conversation

jacquesbh
Copy link
Member

@jacquesbh jacquesbh commented Jul 6, 2020

Previous title: Add method findTypeForMigration to ProductAttributeRepository

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11592
License MIT

I don't know how to test these except by running the database migrations.
So…

I've added the repository in Core because I think it is where it belongs since
the Migrations are in the main App.

@jacquesbh jacquesbh requested a review from a team as a code owner July 6, 2020 22:52
@jacquesbh jacquesbh changed the title Add method findTypeForMigration to ProductAttributeRepository Fix migration Jul 9, 2020
@lchrusciel lchrusciel changed the base branch from master to 1.7 July 10, 2020 08:49
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix-migration" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit 880e801 into Sylius:1.7 Jul 10, 2020
@lchrusciel
Copy link
Member

Thank you, Jacques! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An existing migration is blocking future migrations
2 participants