New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] added default factory for avatar image #11751
Conversation
foxou33
commented
Aug 19, 2020
Q | A |
---|---|
Branch? | 1.7 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | fixes #11163 |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus if I see correctly, we should implement this interface on that class itself
src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
The build should be green after merging #11780 |
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AdminUserExampleFactory.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AdminUserExampleFactory.php
Outdated
Show resolved
Hide resolved
I think I messed up trying to merge #11780. I'm not sure how to revert. |
555917e
to
6e25522
Compare
I've rebased your PR and fixed commits. All of them are still yours, of course :) Let's wait for green build and it is good to go |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions. |
Not stale. Very useful and looks ready to merge, isn't it? |
f8a54d7
to
d1e370f
Compare
Thanks, @foxou33 and @lchrusciel :) |
d1e370f
to
51459e8
Compare
Thank you, @foxou33! 🎉 |
…on fix (lchrusciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes to #11751 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 2538e83 [Minor] Removal of additional spaces and deprecation version fix