Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility with newer version of data collectors #11778

Merged
merged 1 commit into from Sep 15, 2020

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Aug 31, 2020

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets related #10928
License MIT

Error without this change:

HP Fatal error:  Declaration of Sylius\Bundle\ChannelBundle\Collector\ChannelCollector::collect(Symfony\Component\HttpFoundation\Request $request, Symfony\Component\HttpFoundation\Response $response, ?Exception $exception = NULL): void must be compatible with Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect(Symfony\Component\HttpFoundation\Request $request, Symfony\Component\HttpFoundation\Response $response, ?Throwable $exception = NULL) in /var/www/dimedic-reports/current/vendor/sylius/sylius/src/Sylius/Bundle/ChannelBundle/Collector/ChannelCollector.php on line 61

@stloyd stloyd requested a review from a team as a code owner August 31, 2020 12:04
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Józef,

can you rebase to newest master? The build should be green then. BTW. We should probably mark all collectors as @internal And of course, thanks for your contribution :)

@stloyd
Copy link
Contributor Author

stloyd commented Sep 1, 2020

@lchrusciel But master means it's 1.9-dev not 1.8, do we want to not make 1.8 more compatible with Symfony 5?

@lchrusciel
Copy link
Member

My bad, of course to 1.8

@lchrusciel lchrusciel merged commit cd9f00a into Sylius:1.8 Sep 15, 2020
@lchrusciel
Copy link
Member

Thanks, Joseph! 🥇

@stloyd stloyd deleted the bugfix/data-collector branch September 15, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants