Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Admin taxon update: Cannot set child as parent to node #11793

Open
igormukhingmailcom opened this issue Sep 2, 2020 · 3 comments
Open
Labels
Bug Confirmed bugs or bugfixes.

Comments

@igormukhingmailcom
Copy link
Contributor

igormukhingmailcom commented Sep 2, 2020

Sylius version affected: master/>1.7.6

  • We have Cannot set child as parent to node: ... exception if we're trying to set current taxon as parent on taxon update.

Possible solution:

  • Create special endpoint like /admin/ajax/taxons/<ID>/parent/search (new route like sylius_admin_ajax_taxon_parent_by_name_phrase), which will exclude current and child taxons from search
  • Add validator which will check submitted parent taxon is not current one and not one of childs

Related: #11777

@lchrusciel lchrusciel added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Sep 8, 2020
@lchrusciel
Copy link
Member

Validator seems like a simpler option to me.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 25, 2020
@grzegorz-stolarz
Copy link

Coud someone take a look to handle this exception? Not sent 500

@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Oct 29, 2021
@jakubtobiasz jakubtobiasz added Bug Confirmed bugs or bugfixes. and removed Potential Bug Potential bugs or bugfixes, that needs to be reproduced. labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

No branches or pull requests

4 participants