Fix redirection when there is a trailing slash in the products list path

[loic425]

Q	A
Branch?	1.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets
License	MIT

[vvasiloi]

Isn't that something Symfony already does https://symfony.com/doc/current/routing.html#redirecting-urls-with-trailing-slashes?

[loic425]

Isn't that something Symfony already does https://symfony.com/doc/current/routing.html#redirecting-urls-with-trailing-slashes?

Yes, indeed and this is what I use to fix the problem.
But the slug is wrong with the trailing slash.

https://demo.sylius.com/en_US/taxons/caps/with-pompons/
In this example, $slug equals to "taxons/caps/with-pompons/" instead of "taxons/caps/with-pompons" => 404

With my change, the slug is now fixed and Symfony makes a redirection without the trailing slash.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

[Zales0123]

I believe it's still a valid fix 👍 Just should be rebased with 1.8

[loic425]

I believe it's still a valid fix 👍 Just should be rebased with 1.8

@Zales0123 done 👍

[lchrusciel]

Hey Loic,

could you rebase it to 1.10? Would be awesome to have it merged

[loic425]

Hey Loic,

could you rebase it to 1.10? Would be awesome to have it merged

done

[loic425]

@lchrusciel I think you could merge ;)

[lchrusciel]

Suggested change

	@ui
	@ui @no-api

but TBH, I would prefer to do just simple PHPUnit test for that instead of behat

[lchrusciel]

Thank you, Loïc! 🎉