[Api] orders index for customer's account #11891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Sep 30, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | part of #11250 |
| License | MIT |
AdamKasp
changed the title
Tomanhez
approved these changes
Sep 30, 2020
src/Sylius/Bundle/ApiBundle/DataProvider/OrderCollectionDataProvider.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/DataProvider/OrderCollectionDataProviderSpec.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Oct 1, 2020
...count/customer_account/viewing_orders_history/seeing_customer_orders_placed_as_guest.feature
Outdated
Show resolved
Hide resolved
| /** | ||
| * @When I register with previously used :email email and :password password | ||
| */ | ||
| public function iRegisterWithPreviouslyUsedEmailAndPassword(string $email, string $password): void |
There was a problem hiding this comment.
Couldn't it be extracted to RegistrationContext?
There was a problem hiding this comment.
could be... but if I do that I get many names conflicts, so I left it here.
src/Sylius/Bundle/ApiBundle/DataProvider/OrderCollectionDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/OrderCollectionDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Order.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/DataProvider/OrderCollectionDataProviderSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-account-orders-index
branch
from
ba603e0
to
0416f17
Compare
GSadee
reviewed
Oct 1, 2020
| @@ -125,4 +125,14 @@ public function findCartsNotModifiedSince(\DateTimeInterface $terminalDate): arr | |||
| ->getResult() | |||
| ; | |||
| } | |||
|
|
|||
| public function findAllExceptCarts(): array | |||
There was a problem hiding this comment.
I'm not convinced to that name, but for now, I have no better idea
GSadee
approved these changes
Oct 1, 2020
|
Thanks, Adam! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.