Improve 1.8 migrations upgrade instructions #11898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
GSadee
approved these changes
Oct 1, 2020
lchrusciel
approved these changes
Oct 1, 2020
|
Thanks, Mateusz! 馃帀 |
Zales0123
added a commit
that referenced
this pull request
Oct 2, 2020
This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | fixes #11864, continuation of #11898 | License | MIT As I mentionned in [slack](https://sylius-devs.slack.com/archives/CBV3ZLA8P/p1601565976036000?thread_ts=1601372428.024800&cid=CBV3ZLA8P) after trying the fix provided by @Zales0123, there is still a problem when the AdminApiBundle is registered after CoreBundle in `config/bundles.php`. This PR should fix that, by merging the new migration_path of CoreBundle AND AdminApiBundle with the latest migration_path provided in `doctrine_migrations` config. That's the project one. Commits ------- fb5a82d Add migrations_path by merging them with the application one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem with upgrade to Sylius 1.8. I believe it can be done better (duplicated migrations should be detected automatically), but at least it allows to update quite smoothly. The main goal is to delete redundant migrations provided previously in Sylius-Standard (as they're indeed not needed anymore) and mark already executed migrations as migrated.
The change in extension is also fixing the bug, that migrations are generated in vendors instead of
src/Migrationsdirectory.Thank you for all the people involved in fixing this problem, especially for @mmenozzi, @Jibbarth, @chrissnyder2337, Martjn... I hope I didn't miss anyone :) It would be great if you can follow the instruction and check out can you upgrade your store with them.
I also believe we would be able to provide some more elegant solution to this problem as soon as possible 馃枛