[Api] Add validation for add to cart command #11906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Oct 4, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
AdamKasp
force-pushed
the
api-add-validation-to-add-to-cart-command
branch
from
840d35e
to
a7c9bf7
Compare
GSadee
reviewed
Oct 5, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/validation/AddItemToCart.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-add-validation-to-add-to-cart-command
branch
from
a7c9bf7
to
72dcd7b
Compare
AdamKasp
force-pushed
the
api-add-validation-to-add-to-cart-command
branch
from
72dcd7b
to
2f6da52
Compare
GSadee
approved these changes
Oct 14, 2020
| @@ -234,6 +247,17 @@ public function thereShouldBeOneItemInMyCart(): void | |||
| $this->sharedStorage->set('item', $items[0]); | |||
| } | |||
|
|
|||
| /** | |||
| * @Then /^there should be (\d+) item in my (cart)$/ | |||
There was a problem hiding this comment.
Suggested change
| * @Then /^there should be (\d+) item in my (cart)$/ | |
| * @Then /^there should be (\d+) item(?:|s) in my (cart)$/ |
Comment on lines
+255
to
+256
| $response = $this->cartsClient->show($cartToken); | ||
| $items = $this->responseChecker->getValue($response, 'items'); |
There was a problem hiding this comment.
Suggested change
| $response = $this->cartsClient->show($cartToken); | |
| $items = $this->responseChecker->getValue($response, 'items'); | |
| $items = $this->responseChecker->getValue($this->cartsClient->show($cartToken), 'items'); |
?
|
Thanks, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.