Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep it consistent with simple quotes #11923

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

jacquesbh
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Nothing big… The whole file is using simple quotes, so I changed these 4 double quotes.

Code quality comes from small changes.

@jacquesbh jacquesbh requested a review from a team as a code owner October 12, 2020 15:53
@jacquesbh
Copy link
Member Author

Actually I didn't think of hacktoberfest. This PR can be marked as spam and merged anyway, I don't care :-).

@Zales0123
Copy link
Member

Targeting consistency is never a spam @jacquesbh 😄 🖖

@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Oct 15, 2020
@Zales0123 Zales0123 merged commit a372360 into Sylius:master Oct 15, 2020
@Zales0123
Copy link
Member

Thanks, Jacques! 🥇

@vvasiloi
Copy link
Contributor

@Zales0123 what do you think about having a linter for it?
Symfony's lint:yaml command only checks if the syntax is valid.
Found these on the internet: https://github.com/adrienverge/yamllint and https://github.com/stoplightio/spectral
Also remembered https://github.com/sspooky13/yaml-standards from #10943.

@Zales0123
Copy link
Member

@vvasiloi automatization is the thing I admire the most 🖖 I would totally consider it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants