[Api] Change payment method after checkout #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Oct 13, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | part of #11250 |
| License | MIT |
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
a4c9cc1
to
962873c
Compare
AdamKasp
changed the title
GSadee
requested changes
Oct 14, 2020
features/checkout/paying_for_order/changing_payment_method_after_order_confirmation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Payment.xml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-change-payment-method
branch
2 times, most recently
from
d9e52ef
to
f068817
Compare
GSadee
reviewed
Oct 15, 2020
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutThankYouContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/ChoosePaymentMethodHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Doctrine/QueryItemExtension/OrderMethodsItemExtension.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-change-payment-method
branch
3 times, most recently
from
5aa9537
to
27954f2
Compare
lchrusciel
reviewed
Oct 15, 2020
AdamKasp
force-pushed
the
api-change-payment-method
branch
2 times, most recently
from
1cc46ea
to
fd976cc
Compare
Tomanhez
reviewed
Oct 16, 2020
src/Sylius/Bundle/ApiBundle/Doctrine/QueryItemExtension/OrderMethodsItemExtension.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Oct 16, 2020
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/ChoosePaymentMethodHandler.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
13d9996
to
3951feb
Compare
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
3951feb
to
e802597
Compare
GSadee
reviewed
Oct 20, 2020
...s/checkout/paying_for_order/changing_offline_payment_method_after_order_confirmation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutOrderDetailsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutThankYouContext.php
Outdated
Show resolved
Hide resolved
| ): void { | ||
| if ($user instanceof ShopUserInterface && $operationName === 'shop_select_payment_method') { |
There was a problem hiding this comment.
I suggest refactoring the existing code to apply on query builder
->andWhere(sprintf('%s.state = :state', $rootAlias))
->setParameter('state', OrderInterface::STATE_CART)
only if there is an endpoint for checkout.
IMO it could simplify the logic 😃
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
e802597
to
8c4568b
Compare
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
8c4568b
to
33eeea3
Compare
AdamKasp
force-pushed
the
api-change-payment-method
branch
from
996f49b
to
0be4481
Compare
GSadee
approved these changes
Oct 21, 2020
Comment on lines
+54
to
+55
| * @When I change payment method to :paymentMethodName after checkout | ||
| * @When I change payment method to :paymentMethodName |
There was a problem hiding this comment.
I guess that these two steps are not necessary anymore
Suggested change
| * @When I change payment method to :paymentMethodName after checkout | |
| * @When I change payment method to :paymentMethodName |
Tomanhez
approved these changes
Oct 21, 2020
|
Thank you, Adam! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.