Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding select type to doc #11928

Merged
merged 1 commit into from Oct 29, 2020
Merged

Adding select type to doc #11928

merged 1 commit into from Oct 29, 2020

Conversation

moein
Copy link
Contributor

@moein moein commented Oct 13, 2020

I was looking into adding a select type field and I saw that type was added 3 years ago in #4397 but the doc was not updated

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets #4397
License MIT

I was looking into adding a select type field and I saw that type was added 3 years ago in Sylius#4397 but the doc was not updated
@moein moein requested a review from a team as a code owner October 13, 2020 18:59
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 15, 2020
@lchrusciel
Copy link
Member

Hey Moenin,

thanks for your contribution and welcome to our community ;)

@lchrusciel lchrusciel merged commit c64f29a into Sylius:master Oct 29, 2020
@lchrusciel
Copy link
Member

Thank you, @moein! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants