Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][AddressBook] Protect addresses with new firewall #11964

Merged
merged 3 commits into from Oct 30, 2020
Merged

[API][AddressBook] Protect addresses with new firewall #11964

merged 3 commits into from Oct 30, 2020

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner October 27, 2020 09:43
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from b298895 to 146244f Compare October 27, 2020 09:43
@AdamKasp AdamKasp changed the title [API][AddressBook] Protect addressbook with new firewall [WIP][API][AddressBook] Protect addressbook with new firewall Oct 27, 2020
@AdamKasp AdamKasp changed the title [WIP][API][AddressBook] Protect addressbook with new firewall [API][AddressBook] Protect addresses with new firewall Oct 27, 2020
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 88290a7 to 8ae12f2 Compare October 27, 2020 11:47
GSadee
GSadee reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be also scenarios for inability to add and delete an address from address book by a visitor

src/Sylius/Behat/Context/Api/Shop/AddressContext.php Outdated Show resolved Hide resolved
@GSadee GSadee added the API APIs related issues and PRs. label Oct 28, 2020
arti0090
arti0090 reviewed Oct 28, 2020
View reviewed changes
src/Sylius/Behat/Context/Transform/AddressContext.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/DataProvider/AddressItemDataProvider.php
@@ -54,7 +54,7 @@ public function getItem(string $resourceClass, $id, string $operationName = null
in_array('ROLE_USER', $user->getRoles(), true) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not part of this PR but maybe you could change something so $user instanceof ShopUserInterface won't be called 2 times? 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe :D but like you said it isn't the scope of this PR :)

@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 7e47c65 to e823246 Compare October 28, 2020 12:00
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch 2 times, most recently from 4234072 to 8f23152 Compare October 29, 2020 07:10
GSadee
GSadee approved these changes Oct 29, 2020
View reviewed changes
src/Sylius/Behat/Context/Api/Shop/AddressContext.php Outdated Show resolved Hide resolved
UPGRADE-1.9.md Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Shop/AddressContext.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 8f23152 to 100f1da Compare October 30, 2020 06:36
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 100f1da to 1c74e94 Compare October 30, 2020 06:52
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 1c74e94 to 09ce746 Compare October 30, 2020 09:52
@AdamKasp AdamKasp force-pushed the api-protect-operation-on-addressbook-with-firewall-account branch from 09ce746 to 787d7e4 Compare October 30, 2020 09:53
@GSadee GSadee merged commit 93b12d2 into Sylius:master Oct 30, 2020
@GSadee
Copy link
Member

GSadee commented Oct 30, 2020

Thank you, Adam! 🎉

@AdamKasp AdamKasp deleted the api-protect-operation-on-addressbook-with-firewall-account branch July 19, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@GSadee GSadee GSadee approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamKasp @GSadee @lchrusciel @arti0090