[API] Seeing promotions total in cart #11971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Oct 28, 2020
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
changed the title
AdamKasp
suggested changes
Oct 28, 2020
src/Sylius/Behat/Resources/config/suites/api/promotion/receiving_discount.yml
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
api-applying-promotions
branch
from
4b95a89
to
f431fca
Compare
AdamKasp
approved these changes
Oct 28, 2020
GSadee
approved these changes
Oct 29, 2020
arti0090
force-pushed
the
api-applying-promotions
branch
from
f431fca
to
f13e06e
Compare
lchrusciel
reviewed
Oct 29, 2020
| { | ||
| Assert::same($this->responseChecker->getValue($this->client->getResponse(), 'orderPromotionTotal'), 0); | ||
| if ($this->sharedStorage->has('cart_token')) { |
There was a problem hiding this comment.
Does this if makes sense? I would assume that cart_token is always set (as we always have cart declared).
There was a problem hiding this comment.
Yes, because it depends on context where it was started. If steps are all in checkout then they are using $this->client->getResponse() but some steps from cartContext are finished here and those steps are using sharedStorage.
| ); | ||
|
|
||
| Assert::same($discount, (int) $discountTotal); | ||
| } else { |
There was a problem hiding this comment.
Instead of else, can we make early return?
GSadee
approved these changes
Oct 30, 2020
|
Thanks, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.