Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Change localisation of findCartByTokenValue function #12026

Merged
merged 1 commit into from Nov 13, 2020
Merged

[Order] Change localisation of findCartByTokenValue function #12026

merged 1 commit into from Nov 13, 2020

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner November 10, 2020 14:06
@AdamKasp AdamKasp force-pushed the move-get-cart-by-token-function-to-propel-class branch from aaabf00 to 476a1bf Compare November 12, 2020 09:15
@AdamKasp AdamKasp force-pushed the move-get-cart-by-token-function-to-propel-class branch from 476a1bf to c0e5521 Compare November 12, 2020 12:56
@AdamKasp AdamKasp force-pushed the move-get-cart-by-token-function-to-propel-class branch from c0e5521 to 3f0eb32 Compare November 12, 2020 12:56
@AdamKasp AdamKasp changed the title [Order] Change localisation of findOneByTokenValue function [Order] Change localisation of findCartByTokenValue function Nov 12, 2020
Zales0123
Zales0123 reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but some tests failed 💃

@GSadee GSadee merged commit a27aa47 into Sylius:master Nov 13, 2020
@GSadee
Copy link
Member

GSadee commented Nov 13, 2020

Thanks, Adam! 🎉

@AdamKasp AdamKasp deleted the move-get-cart-by-token-function-to-propel-class branch July 19, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stloyd stloyd stloyd left review comments

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AdamKasp @GSadee @stloyd @Zales0123 @lchrusciel