Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXTURES] Use shopbillDataFactory in ChannelExampleFactory #12027

Merged
merged 2 commits into from Nov 13, 2020

Conversation

lukomwro
Copy link

Q A
Branch? 1.8 or master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

ShopBillingData model override (in configuration) breaks fixtures. ShopBillingData should be created from factory instead of Sylius\Component\Core\Model\ShopBillingData class.

@lukomwro lukomwro requested a review from a team as a code owner November 10, 2020 16:08
@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 12, 2020
@Zales0123 Zales0123 changed the base branch from 1.8 to master November 12, 2020 08:19
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix-fixtures-shopbilling-data" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution ;)

@Zales0123 Zales0123 merged commit 18987ff into Sylius:master Nov 13, 2020
@Zales0123
Copy link
Member

Thank you, Łukasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants