Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][BC-Break] Move commands and handlers to common namespace #12029

Merged
merged 1 commit into from Aug 13, 2021
Merged

[API][BC-Break] Move commands and handlers to common namespace #12029

merged 1 commit into from Aug 13, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel requested a review from a team as a code owner November 10, 2020 19:05
@lchrusciel lchrusciel added API APIs related issues and PRs. BC Break PRs introducing BC breaks (do not even try to merge). labels Nov 10, 2020
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 10, 2021
@lchrusciel lchrusciel changed the base branch from master to 1.9 February 10, 2021 12:22
@lchrusciel lchrusciel force-pushed the common-namespace branch 4 times, most recently from 410ad59 to 0bd874b Compare February 23, 2021 10:49
@lchrusciel
Copy link
Member Author

There is some issue with the build https://github.com/Sylius/Sylius/pull/12029/checks?check_run_id=1960471915#step:24:324 :(

@stale
Copy link

stale bot commented Jun 26, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Jun 26, 2021
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Aug 12, 2021
@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Aug 12, 2021
@lchrusciel lchrusciel changed the base branch from 1.9 to master August 12, 2021 20:06
@lchrusciel lchrusciel force-pushed the common-namespace branch 4 times, most recently from b1defa6 to be67376 Compare August 13, 2021 09:55
@lchrusciel lchrusciel changed the title [API] Move account commands to common namespace [API][BC-Break] Move commands and handlers to common namespace Aug 13, 2021
@lchrusciel lchrusciel force-pushed the common-namespace branch 2 times, most recently from 4369d45 to 7840159 Compare August 13, 2021 11:57
@AdamKasp AdamKasp merged commit c40d58d into Sylius:master Aug 13, 2021
@AdamKasp
Copy link
Contributor

Thank you, Łukasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. BC Break PRs introducing BC breaks (do not even try to merge). Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lchrusciel @AdamKasp @Zales0123 @Tomanhez