Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add missing endpoints for address and country resources #12045

Merged
merged 1 commit into from Nov 16, 2020
Merged

[API] Add missing endpoints for address and country resources #12045

merged 1 commit into from Nov 16, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 13, 2020

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Related tickets after #11925
License MIT

@GSadee GSadee added the API APIs related issues and PRs. label Nov 13, 2020
@GSadee GSadee requested a review from a team as a code owner November 13, 2020 13:46
lchrusciel
lchrusciel reviewed Nov 14, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we miss it? Shouldn't we have new endpoints covered by tests as well?

@GSadee
Copy link
Member Author

GSadee commented Nov 16, 2020 •
edited

@lchrusciel these endpoints were not needed in the given contexts so far, but now I have added them to resolve the proper iris in responses

@AdamKasp AdamKasp merged commit f13cc03 into Sylius:master Nov 16, 2020
@AdamKasp
Copy link
Contributor

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the api-proper-iri-fixes-again branch November 16, 2020 07:11
@oallain oallain mentioned this pull request Dec 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@AdamKasp AdamKasp AdamKasp approved these changes

@arti0090 arti0090 arti0090 approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GSadee @AdamKasp @lchrusciel @arti0090 @Tomanhez