Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Explicitly exclude feature from API implementation #12048

Merged
merged 1 commit into from
Feb 26, 2021
Merged

[API] Explicitly exclude feature from API implementation #12048

merged 1 commit into from
Feb 26, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

First excluded scenario from API coverage, to inform that it will not be handled via API

@lchrusciel lchrusciel requested a review from a team as a code owner November 16, 2020 13:55
@oallain
Copy link
Member

oallain commented Nov 21, 2020

This clearly designates what we are not going to test.

@Zales0123 Zales0123 added API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage. labels Nov 21, 2020
@lchrusciel lchrusciel merged commit 909500e into Sylius:master Feb 26, 2021
@lchrusciel
Copy link
Member Author

Thanks, Łukasz! 🥇

@lchrusciel lchrusciel deleted the no-api branch February 26, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@oallain oallain oallain approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lchrusciel @oallain @Zales0123