Refactor mailing #12050
Merged
Refactor mailing #12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Nov 17, 2020
SirDomin
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | not sure |
| Related tickets | refactoring the way we handle emails implemented in #11754 |
| License | MIT |
AdamKasp
reviewed
Nov 17, 2020
src/Sylius/Bundle/ApiBundle/spec/CommandHandler/Checkout/CompleteOrderHandlerSpec.php
Outdated
Show resolved
Hide resolved
|
|
||
| final class SendOrderConfirmationHandlerSpec extends ObjectBehavior | ||
| { | ||
| function let( |
stloyd
suggested changes
Nov 17, 2020
src/Sylius/Bundle/ApiBundle/EventListener/OrderCompleteListener.php
Outdated
Show resolved
Hide resolved
| @@ -66,7 +68,7 @@ public function __invoke(CompleteOrder $completeOrder): OrderInterface | |||
|
|
|||
| $stateMachine->apply(OrderCheckoutTransitions::TRANSITION_COMPLETE); | |||
|
|
|||
| $this->emailManager->sendConfirmationEmail($cart); | |||
| $this->messageBus->dispatch(new OrderCompletedEvent($orderTokenValue), [new DispatchAfterCurrentBusStamp()]); | |||
There was a problem hiding this comment.
It would be good to add comment why you added that stamp here.
lchrusciel
reviewed
Nov 17, 2020
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/CompleteOrderHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/CompleteOrderHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventListener/OrderCompleteListener.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventListener/OrderCompleteListener.php
Outdated
Show resolved
Hide resolved
SirDomin
force-pushed
the
refactor-mailing
branch
from
7e8473d
to
546bafc
Compare
SirDomin
force-pushed
the
refactor-mailing
branch
from
546bafc
to
da13fb2
Compare
GSadee
reviewed
Nov 18, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
Nov 18, 2020
Zales0123
added
DX
Zales0123
reviewed
Nov 18, 2020
src/Sylius/Bundle/ApiBundle/EventHandler/OrderCompletedHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/CommandHandler/Checkout/CompleteOrderHandlerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/CommandHandler/Checkout/CompleteOrderHandlerSpec.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Nov 18, 2020
| $emailManager->sendConfirmationEmail($order)->shouldBeCalled(); | ||
| $orderCompleted = new OrderCompleted('COMPLETED_ORDER_TOKEN'); | ||
|
|
||
| $eventBus->dispatch($orderCompleted, [new DispatchAfterCurrentBusStamp()]) |
There was a problem hiding this comment.
I'm surprised, that it works. I would expect, that the second argument makes a problem with matching to the actual value.
src/Sylius/Bundle/ApiBundle/Resources/config/services/event_handlers.xml
Outdated
Show resolved
Hide resolved
SirDomin
force-pushed
the
refactor-mailing
branch
from
e866c74
to
b7bbf2c
Compare
SirDomin
force-pushed
the
refactor-mailing
branch
from
b7bbf2c
to
b10b272
Compare
GSadee
approved these changes
Nov 19, 2020
|
Thanks, @SirDomin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Nov 19, 2020
This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #12050 | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 02ca9e6 adr how to send email e537bd4 pr-fix
lchrusciel
reviewed
Nov 20, 2020
Comment on lines
+81
to
+82
| <argument type="service" id="sylius_event.bus" /> | ||
| <tag name="messenger.message_handler" bus="sylius_default.bus" /> |
There was a problem hiding this comment.
I'm wondering about naming. Maybe we should have two busses:
- sylius.command_bus
- sylius.event_bus
and try to alias sylius_default.bus to sylius.command_bus if it is possilbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.