Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat]refactor of setup/PromotionContext class #12075

Merged
merged 1 commit into from Nov 23, 2020
Merged

[Behat]refactor of setup/PromotionContext class #12075

merged 1 commit into from Nov 23, 2020

Conversation

arti0090
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
License MIT

Done: add missing return types, add missing variable type, minor improvements

@arti0090 arti0090 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Nov 21, 2020
@arti0090 arti0090 requested a review from a team as a code owner November 21, 2020 17:34
@arti0090 arti0090 changed the title refactor of setup/PromotionContext class [Behat]refactor of setup/PromotionContext class Nov 21, 2020
@arti0090 arti0090 added the Behat Issues and PRs aimed at improving Behat usage. label Nov 21, 2020
@GSadee GSadee merged commit 518b03b into Sylius:master Nov 23, 2020
@GSadee
Copy link
Member

GSadee commented Nov 23, 2020

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arti0090 @GSadee