[Api] Receiving discount promotion #12081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Nov 24, 2020
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Tomanhez
force-pushed
the
reciving-discount-promotion
branch
from
79a333a
to
0ddad77
Compare
AdamKasp
reviewed
Nov 24, 2020
Tomanhez
force-pushed
the
reciving-discount-promotion
branch
from
0ddad77
to
a2cef23
Compare
arti0090
approved these changes
Nov 25, 2020
|
|
||
| $items = $this->responseChecker->getValue($this->cartsClient->getLastResponse(), 'items'); | ||
|
|
||
| foreach ($items as $item) { |
There was a problem hiding this comment.
Suggested change
| foreach ($items as $item) { | |
| $productName = $product->getName(); | |
| foreach ($items as $item) { | |
| if ($item['productName'] === $productName()) { |
in this $product->getName() we will call once but I assume there is not a lot of items in the $items.
There was a problem hiding this comment.
You wrong, look in this scenario: features/promotion/receiving_discount/receiving_discount_from_promotion_with_multiple_actions.feature there are two products
Tomanhez
force-pushed
the
reciving-discount-promotion
branch
from
a2cef23
to
5c28552
Compare
GSadee
approved these changes
Nov 26, 2020
GSadee
reviewed
Nov 26, 2020
lchrusciel
reviewed
Nov 26, 2020
Tomanhez
force-pushed
the
reciving-discount-promotion
branch
from
5c28552
to
377a445
Compare
GSadee
approved these changes
Nov 26, 2020
|
Thank you, Tomasz! 🥇 |
GSadee
added a commit
that referenced
this pull request
Nov 26, 2020
This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | License | MIT This PR is based on #12081 <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 25afe06 Add api tags to behats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.