New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect money format being used #12126
Conversation
Anything blocking this? Just want to make sure this will get merged in the next release. Thanks. |
@pamil Could you include this into the next release? Clearly a bug and simple fix. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Shouldn't it go to the 1.8
branch? It's clearly a bugfix :)
@Zales0123 do you want me to change the base to 1.8? |
This didn't get merged in the last release 🤦 Ping @pamil @lchrusciel |
Ping @pamil again. Think this is an easy bug fix. |
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Only format accept currency as argument. Fix Sylius#11941.
Not sure what you mean, do you still want this branch to merge against 1.8? Anyway I have rebased the commit against the latest 1.8 branch. |
Thanks, @kayue! 🥇 |
Only format accept currency as argument.
Fix #11941.
A "Cart" menu/collector is added in Sylius 1.8, but this feature requires Channel to exist in the debugger/profiler's route, otherwise user will get the following error:
The error is triggered by
convertAndFormat()
in the Twig file. Change it toformat()
fix the problem. I think it was meant to useformat
since method signature was incorrect also.