Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api][Order] Refactor api serialization groups #12188

Merged
merged 2 commits into from Dec 30, 2020
Merged

[Api][Order] Refactor api serialization groups #12188

merged 2 commits into from Dec 30, 2020

Conversation

Tomanhez
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
License MIT

Completed entities:

  • Order

@Tomanhez Tomanhez requested a review from a team as a code owner December 22, 2020 16:12
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Dec 22, 2020
@Tomanhez Tomanhez added BC Break PRs introducing BC breaks (do not even try to merge). Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Dec 22, 2020
@Tomanhez Tomanhez force-pushed the refactor-api-serialization-groups-order branch from a5a1425 to f9db383 Compare December 22, 2020 18:50
GSadee
GSadee reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the rebase is needed

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Order.xml Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the refactor-api-serialization-groups-order branch 2 times, most recently from 2a7d94d to 4c3147a Compare December 29, 2020 20:13
@Tomanhez Tomanhez force-pushed the refactor-api-serialization-groups-order branch from 4c3147a to 25e6ecf Compare December 30, 2020 07:57
@lchrusciel lchrusciel removed the Maintenance CI configurations, READMEs, releases, etc. label Dec 30, 2020
@lchrusciel lchrusciel merged commit ce35ba3 into Sylius:master Dec 30, 2020
@lchrusciel
Copy link
Member

Thank you, Tomasz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. BC Break PRs introducing BC breaks (do not even try to merge). Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tomanhez @lchrusciel @GSadee