Ability to create non-translatable attributes fixtures + info about non-translatable attributes. #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Jan 15, 2021
SirDomin
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixtures + doc for #12098 |
| License | MIT |
SirDomin
added
the
Documentation
SirDomin
force-pushed
the
fixtures-added
branch
from
90073b0
to
ce9039c
Compare
AdamKasp
reviewed
Jan 15, 2021
SirDomin
force-pushed
the
fixtures-added
branch
3 times, most recently
from
fb9985e
to
a5fa3dc
Compare
GSadee
approved these changes
Jan 18, 2021
src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductAttributeExampleFactory.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductExampleFactory.php
Outdated
Show resolved
Hide resolved
| @@ -61,6 +61,11 @@ sylius_fixtures: | |||
| code: 't_shirt_material' | |||
| type: 'text' | |||
|
|
|||
| - name: 'Damage reduction' | |||
There was a problem hiding this comment.
A bit unusual attribute I guess 😃
There was a problem hiding this comment.
its premium bonus :D
SirDomin
force-pushed
the
fixtures-added
branch
from
a5fa3dc
to
25df06c
Compare
GSadee
approved these changes
Jan 18, 2021
|
Thanks, @SirDomin! 🎉 |
lchrusciel
reviewed
Jan 18, 2021
Comment on lines
+43
to
+45
| Warning | ||
|
|
||
| Once the attribute has disabled translatability it will erase attribute values in all locales for this attribute. |
There was a problem hiding this comment.
Suggested change
| Warning | |
| Once the attribute has disabled translatability it will erase attribute values in all locales for this attribute. | |
| .. warning:: | |
| Once the attribute has disabled translatability it will erase attribute values in all locales for this attribute. |
Zales0123
added a commit
that referenced
this pull request
Jan 18, 2021
…lchrusciel) This PR was merged into the 1.9-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | #12256 (comment) | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 6e132c6 [Minor][Documentation] Improve attribute documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.