Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] change new-api prefix to api #12257

Merged
merged 5 commits into from Jan 21, 2021
Merged

[API] change new-api prefix to api #12257

merged 5 commits into from Jan 21, 2021

Conversation

SirDomin
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? i think yes
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin requested a review from a team as a code owner January 18, 2021 08:32
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. labels Jan 18, 2021
GSadee
GSadee reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should definitely be a proper note in the UPGRADE file about these changes

@SirDomin SirDomin force-pushed the new-api-prefix-changed branch 4 times, most recently from 07cb5cc to dc2a42f Compare January 21, 2021 09:06
GSadee
GSadee reviewed Jan 21, 2021
View reviewed changes
config/packages/fos_rest.yaml Outdated Show resolved Hide resolved
config/packages/security.yaml Outdated Show resolved Hide resolved
GSadee
GSadee reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in config/packages should be reflected in UPGRADE file

lchrusciel
lchrusciel reviewed Jan 21, 2021
View reviewed changes
UPGRADE-1.9.md Outdated Show resolved Hide resolved
UPGRADE-1.9.md Outdated Show resolved Hide resolved
@SirDomin SirDomin force-pushed the new-api-prefix-changed branch 3 times, most recently from b018e29 to d2bdb35 Compare January 21, 2021 13:36
pamil
pamil reviewed Jan 21, 2021
View reviewed changes
UPGRADE-1.9.md Show resolved Hide resolved
UPGRADE-1.9.md Outdated Show resolved Hide resolved
UPGRADE-1.9.md Show resolved Hide resolved
UPGRADE-1.9.md Outdated Show resolved Hide resolved
tests/Controller/ProductVariantApiTest.php
@@ -423,7 +423,7 @@ public function it_allows_updating_information_about_product_variant()
<<<EOT
{
"code": "NEW_MUG_CODE",
"version": $version
"version": "$version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that necessary? It isn't API version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its failing without it for some reason :/

@SirDomin SirDomin force-pushed the new-api-prefix-changed branch 2 times, most recently from 648bbab to 956d589 Compare January 21, 2021 13:52
@pamil pamil merged commit aaea4c0 into Sylius:master Jan 21, 2021
@pamil
Copy link
Contributor

pamil commented Jan 21, 2021

Thanks, @SirDomin! 🎉

@GSadee GSadee mentioned this pull request Jan 22, 2021
Merged
Tomanhez added a commit to Sylius/SyliusDemo that referenced this pull request Jan 22, 2021
@Tomanhez
minor #170 [Maintenance] Adjust configs after change new-api to api/v…
1e10f14 
…2 (GSadee)

This PR was merged into the 1.0-dev branch.

Discussion
----------

After Sylius/Sylius#12257

Commits
-------

cb1009c [Maintenance] Adjust configs after change new-api to api/v2
@SirDomin SirDomin mentioned this pull request Jan 25, 2021
Merged
lchrusciel added a commit that referenced this pull request Feb 5, 2021
@lchrusciel
refactor #12278 [API] move security parameters to bundles (SirDomin, …
7fb0810 
…lchrusciel)

This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #12257
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

2b0d76d [API] move security parameters to bundles
a547a3b upgrade UPGRADE.md file
0b7d6af [UPGRADE] Add more precise upgrade note
runesatsna added a commit to runesatsna/SyliusDemo that referenced this pull request Nov 26, 2023
@runesatsna
minor #170 [Maintenance] Adjust configs after change new-api to api/v…
1bdc988 
…2 (GSadee)

This PR was merged into the 1.0-dev branch.

Discussion
----------

After Sylius/Sylius#12257

Commits
-------

cb1009cd2ae245b4bbf03d3b7e3dfb4b42d4674c [Maintenance] Adjust configs after change new-api to api/v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel left review comments

@pamil pamil pamil approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SirDomin @pamil @GSadee @lchrusciel @AdamKasp