[Shipment] Applying discounts and taxes for each shipment #12282
Conversation
GSadee
commented
Jan 27, 2021
GSadee
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | I guess there is no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
GSadee
added
the
Enhancement
| And the order's tax total should be "$24.15" | ||
| And the order's total should be "$129.15" | ||
|
|
||
| @ui @domain |
There was a problem hiding this comment.
I wonder if this scenario should have @ui tag, because multiple shipments in Sylius could be used in background and displayed in admin panel, but there is no possibility to create more than one shipment during our checkout for now.
There was a problem hiding this comment.
Domain test is really nice, but I would leave it with UI test as well. One cannot create multiple shipments in pure Sylius, but it does not take much to change it.
GSadee
force-pushed
the
promotions-with-multiple-shipments
branch
from
f8489f1
to
6e1db83
Compare
probot-autolabeler
bot
added
the
Documentation
| $taxRate = $this->taxRateResolver->resolve($shippingMethod, ['zone' => $zone]); | ||
| if (null === $taxRate) { | ||
| return; | ||
| if (!$order->hasShipments()) { |
There was a problem hiding this comment.
I'm not sure it is 100%. I'm wondering if we can have shippingTotal > 0 with no shipments? Maybe we can make an early return for lack of shipment and then check the total value of it?
There was a problem hiding this comment.
Or at least we should change the error message, as the order may not have any shipment at all.
There was a problem hiding this comment.
To be honest, I tried to keep the previous behaviour as much as possible, this check and error throw was moved here from the private method that was below: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Core/Taxation/Applicator/OrderShipmentTaxesApplicator.php#L96:L105
GSadee
force-pushed
the
promotions-with-multiple-shipments
branch
2 times, most recently
from
a370552
to
31053ce
Compare
probot-autolabeler
bot
added
the
Maintenance
GSadee
force-pushed
the
promotions-with-multiple-shipments
branch
2 times, most recently
from
201a3ae
to
881054e
Compare
GSadee
force-pushed
the
promotions-with-multiple-shipments
branch
from
881054e
to
1e64629
Compare
|
Thank you, Grzegorz! 🥇 |
