Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Psalm] Fix build by casting to string in sprintf methods #12284

Merged
merged 3 commits into from Jan 28, 2021
Merged

[Psalm] Fix build by casting to string in sprintf methods #12284

merged 3 commits into from Jan 28, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jan 28, 2021

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Jan 28, 2021
@GSadee GSadee requested a review from a team as a code owner January 28, 2021 07:09
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jan 28, 2021
@GSadee GSadee force-pushed the psalm-sprintf-fix branch 3 times, most recently from 1720869 to bc571fc Compare January 28, 2021 13:45
@pamil pamil merged commit f25ed64 into Sylius:master Jan 28, 2021
@pamil
Copy link
Contributor

pamil commented Jan 28, 2021

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the psalm-sprintf-fix branch January 28, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GSadee @pamil