Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHPStan configuration #12304

Merged
merged 2 commits into from Feb 5, 2021
Merged

Update PHPStan configuration #12304

merged 2 commits into from Feb 5, 2021

Conversation

szepeviktor
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Putting everything in the config file.

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 3, 2021
@szepeviktor szepeviktor marked this pull request as ready for review February 3, 2021 05:05
@szepeviktor szepeviktor requested a review from a team as a code owner February 3, 2021 05:05
lchrusciel
lchrusciel approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Viktor,

thanks for an improvement and welcome among our contributors 👍

@pamil pamil merged commit afd2bf2 into Sylius:master Feb 5, 2021
@pamil
Copy link
Contributor

pamil commented Feb 5, 2021

Thanks, Viktor! 🥇

@szepeviktor szepeviktor deleted the patch-3 branch February 5, 2021 14:12
@szepeviktor
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szepeviktor @pamil @lchrusciel