Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updating the controller customization #12338

Merged
merged 2 commits into from Feb 12, 2021
Merged

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Feb 12, 2021

Q A
Branch? 1.9
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no (but fixing one :D )
Related tickets N/A
License MIT
  • Fix the last route declaration to its real use
  • Use the term make sure instead of check if since it is should to work
  • use the double : syntax for controllers instead of the deprecated single :

* Fix the last route declaration to its real use
* Use the term `make sure` instead of `check if` since it is should to work
* use the double `:` syntax for controllers instead of the deprecated single `:`
@Roshyo Roshyo requested a review from a team as a code owner February 12, 2021 07:24
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 12, 2021
@AdamKasp AdamKasp changed the title [DOC] Updating the controller customization [DOCS] Updating the controller customization Feb 12, 2021
Change custom route

Co-authored-by: Łukasz Chruściel <lchrusciel@gmail.com>
@GSadee GSadee merged commit 75f6899 into Sylius:1.9 Feb 12, 2021
@GSadee
Copy link
Member

GSadee commented Feb 12, 2021

Thank you, Stephane! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants