[API] Password reset #12360

arti0090 · 2021-02-17T07:57:17Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
License	MIT

src/Sylius/Behat/Context/Api/EmailContext.php

src/Sylius/Bundle/ApiBundle/Command/ResetPasswordRequest.php

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordRequestHandler.php

src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php

src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ShopUser.xml

…behat

arti0090 · 2021-02-18T09:16:56Z

TODO for part 2:

Add phpspecs to new classes
if possible update swagger docs with properties that are needed for password reset
add endpoint for change the password with token from email
implement rest of behat scenarios

src/Sylius/Behat/Client/ApiSecurityClientInterface.php

src/Sylius/Behat/Context/Api/Shop/LoginContext.php

src/Sylius/Behat/Context/Api/EmailContext.php

src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php

src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php

src/Sylius/Bundle/ApiBundle/CommandHandler/SendResetPasswordEmailHandler.php

src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php

src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php

src/Sylius/Behat/Context/Api/EmailContext.php

src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php

src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php

src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml

src/Sylius/Behat/Resources/config/services/contexts/api.xml

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml

src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordRequestHandler.php

src/Sylius/Behat/Resources/config/suites/api/account/login.yml

src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php

src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php

src/Sylius/Bundle/CoreBundle/Resources/views/Email/passwordReset.html.twig

src/Sylius/Behat/Context/Api/Shop/LoginContext.php

src/Sylius/Bundle/ApiBundle/CommandHandler/RequestResetPasswordTokenHandler.php

src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml

src/Sylius/Bundle/ApiBundle/Command/LocaleCodeAwareInterface.php

src/Sylius/Bundle/ApiBundle/Resources/config/validation/ResetPassword.xml

src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/SendResetPasswordEmailHandlerTest.php

src/Sylius/Bundle/ApiBundle/Command/RequestResetPasswordToken.php

src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/SendResetPasswordEmailHandlerTest.php

src/Sylius/Behat/Context/Api/Shop/LoginContext.php

src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/SendResetPasswordEmailHandlerTest.php

lchrusciel · 2021-02-25T12:04:44Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/PasswordReset.xml

+            <collectionOperation name="shop_password_reset_request">
+                <attribute name="method">POST</attribute>
+                <attribute name="path">shop/request-reset-password</attribute>
+                <attribute name="messenger">input</attribute>


Could go to the generic section (below validation_groups)

lchrusciel · 2021-02-25T12:05:03Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/PasswordReset.xml

+                <attribute name="output">false</attribute>
+                <attribute name="status">202</attribute>


Maybe could go to the generic section (below validation_groups)

lchrusciel · 2021-02-25T12:05:39Z

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/PasswordReset.xml

+                <attribute name="status">202</attribute>
+                <attribute name="validation_groups">
+                    <attribute>sylius</attribute>
+                    <attribute>sylius_shop_password_reset</attribute>


is this group needed?

lchrusciel · 2021-02-25T12:09:11Z

Thank you, @arti0090! 🥇

arti0090 requested a review from a team as a code owner February 17, 2021 07:57

probot-autolabeler bot added API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels Feb 17, 2021

GSadee reviewed Feb 17, 2021

View reviewed changes

arti0090 added 3 commits February 18, 2021 08:31

[API] Password reset

0ce0173

change email templates

9740b92

fixes, revert ApiPlatformSecurityClient and use ApiClient instead in …

6d453ce

…behat

arti0090 force-pushed the api-resetting-password branch from 10e13e8 to 6d453ce Compare February 18, 2021 07:31

fix config files

ecadef4

arti0090 force-pushed the api-resetting-password branch from e8dbb38 to ecadef4 Compare February 18, 2021 07:55

arti0090 added 2 commits February 18, 2021 10:06

validate email

3759b2b

fix behat step

e58e741

arti0090 changed the title ~~[WIP][API] Password reset~~ [API] Password reset Feb 18, 2021

arti0090 commented Feb 18, 2021

View reviewed changes

src/Sylius/Behat/Client/ApiSecurityClientInterface.php Outdated Show resolved Hide resolved

arti0090 commented Feb 18, 2021

View reviewed changes

src/Sylius/Behat/Context/Api/Shop/LoginContext.php Outdated Show resolved Hide resolved

arti0090 force-pushed the api-resetting-password branch from dc43d89 to 21d724c Compare February 18, 2021 09:56

remove unneded elements

656719d

arti0090 force-pushed the api-resetting-password branch from 21d724c to 656719d Compare February 18, 2021 10:25

Tomanhez reviewed Feb 18, 2021

View reviewed changes

lchrusciel reviewed Feb 18, 2021

View reviewed changes

GSadee reviewed Feb 19, 2021

View reviewed changes

src/Sylius/Behat/Resources/config/services/contexts/api.xml Outdated Show resolved Hide resolved

src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml Outdated Show resolved Hide resolved

add copyright blocks, add phpspec for handler, fix issues

5bc148c

arti0090 force-pushed the api-resetting-password branch from 249185e to 5bc148c Compare February 19, 2021 09:25

AdamKasp suggested changes Feb 19, 2021

View reviewed changes

arti0090 added 3 commits February 19, 2021 11:26

change access modifiers

1ecde8f

decouple mail

66d5b0d

remove events

f575fa3

lchrusciel reviewed Feb 24, 2021

View reviewed changes

add test for send reset password email

47e3307

AdamKasp approved these changes Feb 24, 2021

View reviewed changes

fixes

e79526a

arti0090 force-pushed the api-resetting-password branch from 7dd3ed4 to e79526a Compare February 24, 2021 13:32

Tomanhez reviewed Feb 24, 2021

View reviewed changes

GSadee reviewed Feb 25, 2021

View reviewed changes

src/Sylius/Behat/Context/Api/Shop/LoginContext.php Outdated Show resolved Hide resolved

src/Sylius/Bundle/ApiBundle/Tests/CommandHandler/SendResetPasswordEmailHandlerTest.php Outdated Show resolved Hide resolved

arti0090 force-pushed the api-resetting-password branch from cddf339 to 68049ef Compare February 25, 2021 07:28

more fixes

53e2976

arti0090 force-pushed the api-resetting-password branch from 68049ef to 53e2976 Compare February 25, 2021 07:29

change configuration for endpoint to custom resource

72aa4fc

lchrusciel approved these changes Feb 25, 2021

View reviewed changes

lchrusciel merged commit 29b5d2d into Sylius:master Feb 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API] Password reset #12360

[API] Password reset #12360

arti0090 commented Feb 17, 2021

arti0090 commented Feb 18, 2021 •

edited

lchrusciel Feb 25, 2021

lchrusciel Feb 25, 2021

lchrusciel Feb 25, 2021

lchrusciel commented Feb 25, 2021

		<attribute name="output">false</attribute>
		<attribute name="status">202</attribute>

[API] Password reset #12360

[API] Password reset #12360

Conversation

arti0090 commented Feb 17, 2021

arti0090 commented Feb 18, 2021 • edited

lchrusciel Feb 25, 2021

Choose a reason for hiding this comment

lchrusciel Feb 25, 2021

Choose a reason for hiding this comment

lchrusciel Feb 25, 2021

Choose a reason for hiding this comment

lchrusciel commented Feb 25, 2021

arti0090 commented Feb 18, 2021 •

edited