[API] change variants to iri + tests #12366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirDomin
commented
Feb 18, 2021
SirDomin
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
SirDomin
force-pushed
the
product-serialization-fix
branch
from
fbd122d
to
180be5d
Compare
arti0090
approved these changes
Feb 18, 2021
SirDomin
force-pushed
the
product-serialization-fix
branch
from
180be5d
to
0c53852
Compare
lchrusciel
approved these changes
Feb 18, 2021
SirDomin
force-pushed
the
product-serialization-fix
branch
from
0c53852
to
ecac115
Compare
GSadee
reviewed
Feb 19, 2021
GSadee
approved these changes
Feb 19, 2021
Comment on lines
+190
to
+192
| $this->client->executeCustomRequest(Request::custom($channelPricingIri, HttpRequest::METHOD_GET)); | ||
|
|
||
| $channelPricing = $this->responseChecker->getResponseContent($this->client->getLastResponse()); |
There was a problem hiding this comment.
Suggested change
| $this->client->executeCustomRequest(Request::custom($channelPricingIri, HttpRequest::METHOD_GET)); | |
| $channelPricing = $this->responseChecker->getResponseContent($this->client->getLastResponse()); | |
| $response = $this->client->executeCustomRequest(Request::custom($channelPricingIri, HttpRequest::METHOD_GET)); | |
| $channelPricing = $this->responseChecker->getResponseContent($response); |
lchrusciel
approved these changes
Feb 19, 2021
|
Thanks, @SirDomin! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Feb 19, 2021
This PR was merged into the 1.10-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT <!-- - Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- ecac115 [API] change variants to iri + tests af6a8e5 get resources from request
pamil
added a commit
that referenced
this pull request
Feb 23, 2021
* 1.9: Change application's version to v1.9.0-DEV Change application's version to v1.9.0-RC.2 Generate changelog for v1.9.0-RC.2 [Admin] Fix default form problem with _token field Change application's version to v1.9.0-DEV Change application's version to v1.9.0-RC.1 Generate changelog for v1.9.0-RC.1 Move some steps to different section in the UPGRADE-1.9 file refactor #12366 [API] change variants to iri + tests (SirDomin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.